Re: pidfile_open incorrectly returns EAGAIN when pidfile is lock
--cWoXeonUoKmBZSoM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Mar 14, 2013 at 10:11:07AM -0700, Chuck Swiger wrote:
> Hi--
>=20
> On Mar 14, 2013, at 9:50 AM, John Baldwin wrote:
> > On Thursday, March 14, 2013 12:29:58 pm Pawel Jakub Dawidek wrote:
>=20
> [ ... ]
> >> Heh, I did consider that as well, but here you check errno twice,
> >> instead of once. Guys, is there anything wrong with the patch I
> >> proposed?
> >=20
> > I'm sure the compiler can work that out just fine and it should do what=
ever
> > is most readable to the programmer. I don't care either way.
>=20
> Strong +1. Having the code be correct and readable is much more important
> then trying to hand-optimize a single-digit # of integer compares in
> startup code that usually runs ~once per process.
Well, I think my version is more obvious, just the diff is larger.
Anyway, I think enough has been said already about this crucial change:)
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://tupytaj.pl
--cWoXeonUoKmBZSoM
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlFCMS0ACgkQForvXbEpPzT25ACgzB7icyos1h0RnM56kRx7AGHI
HuEAnij80bFynlzTeZycNPCKbLnYfNg7
=29eY
-----END PGP SIGNATURE-----
--cWoXeonUoKmBZSoM--
討論串 (同標題文章)
完整討論串 (本文為第 14 之 14 篇)：