Re: pidfile_open incorrectly returns EAGAIN when pidfile is lock
--5CUMAwwhRxlRszMD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Mar 13, 2013 at 10:59:17PM +0100, Dirk Engling wrote:
>=20
> On Wed, 13 Mar 2013, Pawel Jakub Dawidek wrote:
>=20
> > How about this patch?
> >
> > http://people.freebsd.org/~pjd/patches/pidfile.c.patch
>=20
> If you move the lines
>=20
> + if (errno =3D=3D 0 || errno =3D=3D EAGAIN)
> + errno =3D EEXIST;
>=20
> out of the else branch, you can get rid of the if branch, guard the else=
=20
> branch by a
>=20
> + if (pidptr) {
>=20
> and let the if (errno =3D=3D 0 || errno =3D=3D EAGAIN) fix the errno
I think I considered something similar at first, but the change I
proposed was optimal, IMHO at the cost of producing pretty large diff,
because of indentation change. But to be sure, can you send a patch of
your proposed change?
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://tupytaj.pl
--5CUMAwwhRxlRszMD
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlFA+N8ACgkQForvXbEpPzSwOwCgucrbfgLbYpEndajoK84jzNel
TbYAoIlOUughbXL1fwTXkqucJtyv4pNk
=Nnvl
-----END PGP SIGNATURE-----
--5CUMAwwhRxlRszMD--
討論串 (同標題文章)
完整討論串 (本文為第 14 之 14 篇)：