Re: Phabric IDs / URLs in commits

On 11 July 2014 12:38, John Baldwin <jhb@freebsd.org> wrote:
>>   CR:                 https://phabric.freebsd.org/D312
>>   Reviewed by:        jilles
>>   MFC after:  1 week
>
> Just picking my own commit here as a sample case.
>
> I think we should be annotating commits with phabricator code reviews in some
> way when a change has gone through that review.  It is very useful to get back
> to the review details from the commit log message in svnweb, etc.

FYI, Phabricator's canonical format for this is:
Differential Revision: http://phabric.freebsd.org/D312
It will then automatically associate the commit with the review and
close the review.

See for example LLVM review D4563:

Review: http://reviews.llvm.org/D4563
Commit: http://reviews.llvm.org/rL213304
(from LLVM's Phabricator repo browser; LLVM's viewvc seems to be down
at the moment.)

"Differential Revision" seems a bit unwieldy and "CR" does fit in
better with our other tags.  But we'll want to teach Phabricator to
parse our custom tag if we go that way.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"