Re: Phabric IDs / URLs in commits
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Ujepg7dRxPMaVtFtBurBQ3nhNsPU6e7CV
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 7/11/2014 11:38 AM, John Baldwin wrote:
> On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote:
>> Author: jhb
>> Date: Fri Jul 11 16:16:26 2014
>> New Revision: 268531
>> URL: http://svnweb.freebsd.org/changeset/base/268531
>>
>> Log:
>> Fix some edge cases with rewinddir():
>> - In the unionfs case, opendir() and fdopendir() read the directory'=
s full
>> contents and cache it. This cache is not refreshed when rewinddir=
() is
>> called, so rewinddir() will not notice updates to a directory. Fi=
x this
>> by splitting the code to fetch a directory's contents out of
>> __opendir_common() into a new _filldir() function and call this fr=
om
>> rewinddir() when operating on a unionfs directory.
>> - If rewinddir() is called on a directory opened with fdopendir() be=
fore
>> any directory entries are fetched, rewinddir() will not adjust the=
seek
>> location of the backing file descriptor. If the file descriptor p=
assed
>> to fdopendir() had a non-zero offset, the rewinddir() will not rew=
ind to
>> the beginning. Fix this by always seeking back to 0 in rewinddir(=
).
>> This means the dd_rewind hack can also be removed.
>> =20
>> While here, add missing locking to rewinddir().
>> =20
>> CR: https://phabric.freebsd.org/D312
>> Reviewed by: jilles
>> MFC after: 1 week
>=20
> Just picking my own commit here as a sample case.
>=20
> I think we should be annotating commits with phabricator code reviews i=
n some=20
> way when a change has gone through that review. It is very useful to g=
et back
> to the review details from the commit log message in svnweb, etc.
>=20
> I can see a number of different ways to do this, but I do think it woul=
d be
> nice to pick a consistent way to do it.
>=20
> Things to consider:
>=20
> 1) The tag ("CR:" is what I used above). I don't care, just pick one. =
I
> chose CR since Warner used it previously. Whatever we decide, we sh=
ould
> add it to the template.
>=20
> 2) ID vs full URL. For PRs we just list the bug ID and not the full UR=
L
> (same for Coverity). I would be fine with that so long as someone h=
acks
> up svnweb to convert the IDs into links (the way it handles PR bug
> numbers). OTOH, if you use the full URL you get that for free in sv=
nweb,
> and you also get it in mail clients, etc. It helps that the URL isn=
't but
> so long.
>=20
> This is more of a pie-in-the-sky, but it would be _really_ nice if arca=
nist=20
> were hacked up to support our local commit template and would auto popu=
late=20
> the 'Reviewed by' and 'CR' (or whatever it ends up being called) fields=
so one=20
> could use 'arc commit'.
>=20
> So what do folks prefer for 1) and 2)?
>=20
FYI Ports has been using the convention: "Phabric\tDXXX"
--=20
Regards,
Bryan Drewery
--Ujepg7dRxPMaVtFtBurBQ3nhNsPU6e7CV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTwBUSAAoJEDXXcbtuRpfPtyUH/3BZ3GpF4MaRj5dz32bRXibU
OF8G6KcX9mCutllsESbb+GRkA7Z9b32BSpKR04hcg0NO2NJ400zZcTEqb54ktBGy
RdL1VaRKx0rJ7xJWN5N6FoThB7GYse5pPqhobMiqkIxelF0bQF4+ZtCDEuevbMz9
OfzlmnWHPJTSM6Ytqr6ahhphmOgOM/inGHEcrvgUTZlNFkTj2vZE7MNSneiEit7q
jpcpIfpe8dLx1JKy6Zgw97bX+bMuzLzOMPemLSBOYYtMHpwLanc5mscaR4ziVeqv
DqBd3CijGr2RxRraxMPfyrum/6kGyoMofmnHTrh+IMs1XFJX9xXfaJtX/UkJjt4=
=Clca
-----END PGP SIGNATURE-----
--Ujepg7dRxPMaVtFtBurBQ3nhNsPU6e7CV--
討論串 (同標題文章)
完整討論串 (本文為第 5 之 13 篇)：