Re: cvs commit: ports/games/gcompris Makefile distinfo pkg-descr
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig92BC51F435B748A8C28B4EF3
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable
On 14/07/2012 08:51, Alexey Dokuchaev wrote:
> On Sat, Jul 14, 2012 at 11:32:56AM +0400, Ruslan Mahmatkhanov wrote:
>> Alexey Dokuchaev wrote on 14.07.2012 11:03:
>>> On Fri, Jul 13, 2012 at 10:23:50AM +0000, Koop Mast wrote:
>>>> kwm 2012-07-13 10:23:50 UTC
>>>>
>>>> Modified files:
>>>> games/gcompris Makefile distinfo pkg-descr pkg-plist
>>>> Log:
>>>> [...]
>>>> Add tab in WWW line in pkg-descr.
>>>
>>> I think the last change takes us backwards: space is preferred separa=
tor in
>>> WWW: line of pkg-descr AFAICT.
>>
>> I always replace this space with a tab (in a manner as vars and values=
=20
>> are separated in Makefile). Does it documented somewhere? And what the=
=20
>> reason may be of space is preferable? Thanks.
>=20
> Well, pkg-descr is not a Makefile. In makefiles, tabs help to align th=
e
> values nicely, as it helps readability a lot. On the contrary, pkg-des=
cr is
> mostly simple text, so there is not need to abuse tab here where single=
> space perfectly suffices and IMHO looks a lot better.
>=20
> Sadly, as with other stylish rather than functional issues, it does not=
seem
> to be documented. Hopefully after switch to SVN it would be easier to
> isolate this kind of mechanical commits, and I will ask permission to
> convert every port to single space + submit a patch to someone on doc@ =
team
> to be added to PH.
Actually, it would make a lot of sense to take the WWW entries out of
pkg-descr files entirely, and have them a variable in the main port
Makefile instead.
This would, at a stroke, reduce the number of files that need to be read
to generate the INDEX by a factor of around 2, and consequentially speed
things up.
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey
--------------enig92BC51F435B748A8C28B4EF3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlABKGIACgkQ8Mjk52CukIyerACfT+nN5u+A3jJD9Be5Alh6y76W
2MAAoJIH1EALPB0ZCzMlweLL3XkIgYxC
=bMtK
-----END PGP SIGNATURE-----
--------------enig92BC51F435B748A8C28B4EF3--
討論串 (同標題文章)
完整討論串 (本文為第 7 之 7 篇)：