Re: cvs commit: ports/graphics Makefile ports/graphics/viewnior

--d6Gm4EdcadzBjdND
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 01, 2012 at 11:43:57PM +0200, nemysis wrote:
> On Wed, 2 May 2012 06:45:22 +1000
> Peter Jeremy <peterjeremy@acm.org> wrote:
> 
> > On 2012-Apr-30 17:52:56 +0000, Guido Falsi <madpilot@FreeBSD.org> wrote:
> > >  This is Viewnior, an image viewer program. Created to be simple, fast
> > >  and elegant. It's minimalistic interface provides more screenspace for
> > >  your images. Among its features are:
> > 
> > This looks interesting, thanks.
> > 
> > I notice that NLS is a configure-time option but USE_GETTEXT is
> > unconditionally set (as well as being set within the !WITHOUT_NLS
> > condtiional block).  I presume this is a cut-and-paste error.
> > 
> 
> 
> I have seen that in FreeBSD Ports collection is older version as you have
> give me and i have adjusted.
> 
> diff -ruN viewnior.old viewnior > viewnior.diff
> 
> Should I this send to freebsd-ports-bugs@freebsd.org

I see that the problem is caused by USE_GETTEXT being defined both
unconditionally and in the option check. Sorry, this is my fault.

If you approve I'd commit the attached simple fix.

-- 
Guido Falsi <madpilot@FreeBSD.org>

--d6Gm4EdcadzBjdND
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="viewnior.diff"

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/viewnior/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile

--- Makefile	30 Apr 2012 17:52:55 -0000	1.1
+++ Makefile	2 May 2012 08:44:54 -0000
@@ -20,7 +20,6 @@
 
 GNU_CONFIGURE=	yes
 USE_AUTOTOOLS=	autoconf
-USE_GETTEXT=	yes
 USE_GMAKE=	yes
 USE_GNOME=	glib20 gtk20 intltool pkgconfig
 INSTALLS_ICONS=	yes

--d6Gm4EdcadzBjdND
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
--d6Gm4EdcadzBjdND--

