Re: cvs commit: ports/www/py-google-api-python-client Makefile

Hi Nicola,

Nicola Vitale wrote on 30.04.2012 12:56:
> nivit       2012-04-30 08:56:32 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      www/py-google-api-python-client Makefile distinfo pkg-descr
>                                      pkg-plist
>    Log:
>    - Update to 1.0.b8
>    - Add devel/py-simplejson to *_DEPENDS
>    - Add www/py-WebTest to RUN_DEPENDS
>    - Add LICENSE (AL2)
>    - Add some API names to pkg-descr
>    - Remove DISTNAME from Makefile
>
>    Revision  Changes    Path
>    1.3       +8 -5      ports/www/py-google-api-python-client/Makefile
>    1.3       +2 -2      ports/www/py-google-api-python-client/distinfo
>    1.2       +5 -2      ports/www/py-google-api-python-client/pkg-descr
>    1.3       +211 -364  ports/www/py-google-api-python-client/pkg-plist

It only using simplejson as a fallback for python <2.6. See setup.py:

"""
try:
   import json
   needs_json = False
except ImportError:
   needs_json = True

if needs_json:
   install_requires.append('simplejson')
"""

and in google-api-python-client-1.0beta8/oauth2client/anyjson.py:

"""
try: # pragma: no cover
   # Should work for Python2.6 and higher.
   import json as simplejson
except ImportError: # pragma: no cover
   try:
     import simplejson
"""

So simplejson dependency isn't needed here (python 2.4/2.5 are EOL and 
subject of removal).
And BUILD_DEPENDS seems redundant, because this deps is only defined in 
install_requires (read, RUN_DEPENDS), not in setup_requires 
(BUILD_DEPENDS equivalent). So I'd drop it too, but needs tinderbox check.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"