[rfc] /dev/devstat permissions patch

看板FB_current作者時間11年前 (2014/03/19 03:32), 編輯推噓0(000)
留言0則, 0人參與, 最新討論串1/4 (看更多)
hello, would anyone object to the following patch? == Index: subr_devstat.c =================================================================== --- subr_devstat.c (revision 263311) +++ subr_devstat.c (working copy) @@ -503,7 +503,7 @@ mtx_assert(&devstat_mutex, MA_NOTOWNED); if (!once) { make_dev_credf(MAKEDEV_ETERNAL | MAKEDEV_CHECKNAME, - &devstat_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0400, + &devstat_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0444, DEVSTAT_DEVICE_NAME); once = 1; } == i'm not sure why /dev/devstat has such restrictive permissions. can someone please explain the reason for it? having gstat(8) require super-user privilege seems like an overkill me. iostat(8) and systat(1) do not require super-user privileges to work. and, yes, i know i can override permissions with /etc/devfs.conf, just curious what are we protecting from in /dev/devstat thanks, max _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
文章代碼(AID): #1JA9ypb9 (FB_current)
文章代碼(AID): #1JA9ypb9 (FB_current)