Re: patch: enable MEM_LOAD_UOPS_LLC_HIT_RETIRED on sandy bridge

On Wed, Aug 14, 2013 at 10:58 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> Hi,
>
> This (and maybe more?) events are applicable to both the sandy bridge and
> sandy bridge xeon CPUs.
>
> This is from the Intel SDM June 2013 Volume #3.
>
> David/Jim, does this look fine to you?
>
> Thanks,
>
>
> ndex: sys/dev/hwpmc/hwpmc_core.c
> ===================================================================
> --- sys/dev/hwpmc/hwpmc_core.c  (revision 254263)
> +++ sys/dev/hwpmc/hwpmc_core.c  (working copy)
> @@ -1541,13 +1541,18 @@
>         IAP_F_SBX | IAP_F_IBX | IAP_F_HW),
>
>      IAPDESCR(D2H_01H, 0xD2, 0x01, IAP_F_FM | IAP_F_CA | IAP_F_CC2 |
> -       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW),
> +       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IAP_F_IB |
> +       IAP_F_IBX | IAP_F_HW),
>      IAPDESCR(D2H_02H, 0xD2, 0x02, IAP_F_FM | IAP_F_CA | IAP_F_CC2 |
> -       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW),
> +       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB |
> +       IAP_F_IBX | IAP_F_HW),
>      IAPDESCR(D2H_04H, 0xD2, 0x04, IAP_F_FM | IAP_F_CA | IAP_F_CC2 |
> -       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW),
> +       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB |
> +       IAP_F_IBX | IAP_F_HW),
>      IAPDESCR(D2H_08H, 0xD2, 0x08, IAP_F_FM | IAP_F_CA | IAP_F_CC2 |
> -       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW),
> +       IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB |
> +       IAP_F_IBX | IAP_F_HW),
> +
>      IAPDESCR(D2H_0FH, 0xD2, 0x0F, IAP_F_FM | IAP_F_CA | IAP_F_CC2 |
>         IAP_F_I7 | IAP_F_WM),
>      IAPDESCR(D2H_10H, 0xD2, 0x10, IAP_F_FM | IAP_F_CC2E),
>

Yes, this looks good for me, but it's incomplete.
You need at least to put the event alias for both Sandy Bridge and
Sandy Bridge Xeon in sys/dev/hwpmc/pmc_events.h
Also, you tested the aforementioned events one by one to see if the
pmc is allocated etc...?

Thanks,

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"