Re: [PATCH] nvmecontrol breaks world

On Tue, Jul 02, 2013 at 10:37:35PM +0200, Dimitry Andric wrote:
> On Jul 2, 2013, at 22:30, Ed Schouten <ed@80386.nl> wrote:
> > 2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>:
> >> Could someone (this could even be me, but need approval) please
> >> fix nvmecontrol?
> > 
> > off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
> 
> Yes, that is what Bruce has suggested for off_t many times in the past. :-)
> 
> 
> > Also, the call of malloc(sb.st_size) is not really safe...
> 
> Sure, but that does not break buildworld (for gcc users, I assume? the tinderboxes are all green).
> 

A gcc-only buildworld is broken on i386 without my patch.  See

http://lists.freebsd.org/pipermail/svn-src-all/2013-July/070954.html

-- 
Steve
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"