Re: openjdk6 broken on current
--7JtmyEQckRKrnqj+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, May 08, 2013 at 11:52:24AM -0500, Larry Rosenman wrote:
> ...
> >Did/can you try just backing out r249606?
> ...
> How can I generate a patch to do that?=20
> ...
(Note that /S4/usr/src is where my "head" sources are on this machine at
present.)
d129(9.1-S)[5] cd /S4/usr/src
d129(9.1-S)[6] svn diff -c -249606
Index: lib/libthr/thread/thr_sig.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- lib/libthr/thread/thr_sig.c (revision 249606)
+++ lib/libthr/thread/thr_sig.c (revision 249605)
@@ -732,12 +732,8 @@
{
ucontext_t uc;
=20
- if (ucp =3D=3D NULL)
- return (EINVAL);
- if (!SIGISMEMBER(uc.uc_sigmask, SIGCANCEL))
- return __sys_setcontext(ucp);
(void) memcpy(&uc, ucp, sizeof(uc));
- SIGDELSET(uc.uc_sigmask, SIGCANCEL);
+ remove_thr_signals(&uc.uc_sigmask);
return __sys_setcontext(&uc);
}
=20
@@ -747,13 +743,7 @@
{
ucontext_t uc;
=20
- if (oucp =3D=3D NULL || ucp =3D=3D NULL)
- return (EINVAL);
- if (SIGISMEMBER(ucp->uc_sigmask, SIGCANCEL)) {
- stdout_debug("remove SIGCANCEL\n"); =20
- (void) memcpy(&uc, ucp, sizeof(uc));
- SIGDELSET(uc.uc_sigmask, SIGCANCEL);
- ucp =3D &uc;
- }
- return __sys_swapcontext(oucp, ucp);
+ (void) memcpy(&uc, ucp, sizeof(uc));
+ remove_thr_signals(&uc.uc_sigmask);
+ return __sys_swapcontext(oucp, &uc);
}
d129(9.1-S)[7]=20
In practice, I would have saved that to a file, then fed it to "svn patch".
Peace,
david
--=20
David H. Wolfskill david@catwhisker.org
Taliban: Evil men with guns afraid of truth from a 14-year old girl.
See http://www.catwhisker.org/~david/publickey.gpg for my public key.
--7JtmyEQckRKrnqj+
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlGKhBcACgkQmprOCmdXAD2L1wCggAIEMEGuhkdYHoGTqUc5KgFi
lLUAn1TZL6OByxjDF42gDn2RXDrSYMGn
=uGmD
-----END PGP SIGNATURE-----
--7JtmyEQckRKrnqj+--
討論串 (同標題文章)
完整討論串 (本文為第 8 之 16 篇)：