Re: acpi resume related patch
--VbJkn9YxBvnuCH5J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Jan 26, 2013 at 04:18:57PM +0200, Andriy Gapon wrote:
> on 25/01/2013 18:08 Andriy Gapon said the following:
> > on 25/01/2013 15:51 John Baldwin said the following:
> >> On Friday, January 25, 2013 3:43:33 am Andriy Gapon wrote:
> >>>
> >>> If you have ACPI suspend/resume working, if it used to work but stopp=
ed working
> >>> at some time, if it never worked, but you are still hoping, could you=
please
> >>> test the following patch and report back?
> >>>
> >>> http://svn.freebsd.by/files/acpi-apic-wakeup-final.patch
> >>
> >> This will break systems not using the local APIC since you uncondition=
ally
> >> call lapic_setup() on resume.This was part of the feature of the previ=
ous
> >> code that by using a dummy pic it could register it only when the loca=
l APIC
> >> was used.
> >=20
> > Thank you for drawing my attention to this. I will try to fix this iss=
ue.
> > The reason I want to remove lapic from 'pics' (and I already described =
it in a
> > private email) is that Local APIC is a special kind of PIC. It's alrea=
dy
> > explicitly initialized by APs. Putting it into 'pics' tailq just obfus=
cates the code.
> >=20
> >> It should also be registered before any of the I/O APICs are by
> >> the design of the local_apic.c code.
> >=20
> > In fact, as I see in the code, Local APIC is always registered _after_ =
I/O APICs.
> > And thus lapic_resume was called after ioapic_resume.
> > Additionally, currently there is no synchronization between initializat=
ion of
> > Local APICs on APs and initialization of I/O APICs at the wakeup/resume=
time.
> >=20
>=20
> Here is an updated version of the patch:
> http://people.freebsd.org/~avg/acpi-apic-wakeup.2.patch
FYI, it doesn't change anything for me. Resume seems to work, but
suspend just reset my laptop.
I unload all driver modules (including if_em, sound, nvidia, usb).
The only driver I keep is ahci.
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://tupytaj.pl
--VbJkn9YxBvnuCH5J
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlEGctEACgkQForvXbEpPzRAEACg8wl3lXy0VJAPofdZLnHFs0+6
+TAAn1wxys7UTovNR+OJnCLGXLzvd2qr
=5yct
-----END PGP SIGNATURE-----
--VbJkn9YxBvnuCH5J--
討論串 (同標題文章)
完整討論串 (本文為第 20 之 20 篇)：