Re: SU+J on 9.1-RC2 ISO

----Next_Part(Sun_Nov__4_21_13_36_2012_719)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi all.

The point is:

    There is completely no way to take a snapshot of SU+J partition
    unless modify one's kernel.

Whether some issue still exist or not,
how about enabling snapshoting SU+J partition
through sysctl variable?

Would you mind to see patch attached?

1. Taking a snapshot of SU+J partition is controlled through sysctl variable.

2. Default to disable.
   One who want to enable it should set the variable manually.

3. The default value in bsdinstall(8) may be left as is.
--
HATANO Tomomi.
----Next_Part(Sun_Nov__4_21_13_36_2012_719)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="snapsuj.patch"

--- src/sys/ufs/ffs/ffs_snapshot.c.orig	2012-11-04 11:01:58.000000000 +0900
+++ src/sys/ufs/ffs/ffs_snapshot.c	2012-11-04 11:13:32.000000000 +0900
@@ -182,8 +182,10 @@
  */
 int dopersistence = 0;
 
-#ifdef DEBUG
 #include <sys/sysctl.h>
+int snapsuj = 0;
+SYSCTL_INT(_debug, OID_AUTO, snapsuj, CTLFLAG_RW, &snapsuj, 0, "");
+#ifdef DEBUG
 SYSCTL_INT(_debug, OID_AUTO, dopersistence, CTLFLAG_RW, &dopersistence, 0, "");
 static int snapdebug = 0;
 SYSCTL_INT(_debug, OID_AUTO, snapdebug, CTLFLAG_RW, &snapdebug, 0, "");
@@ -230,7 +232,7 @@
 	 * At the moment, journaled soft updates cannot support
 	 * taking snapshots.
 	 */
-	if (MOUNTEDSUJ(mp)) {
+	if (MOUNTEDSUJ(mp) && (snapsuj == 0)) {
 		vfs_mount_error(mp, "%s: Snapshots are not yet supported when "
 		    "running with journaled soft updates", fs->fs_fsmnt);
 		return (EOPNOTSUPP);

----Next_Part(Sun_Nov__4_21_13_36_2012_719)--
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
----Next_Part(Sun_Nov__4_21_13_36_2012_719)----

