Re: PAM passwdqc, strict aliasing, and WARNS
--O2g7+miYGsIKoR9l
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jul 15, 2012 at 12:09:17AM +0200, Dag-Erling Sm=C3=B8rgrav wrote:
> "Justin T. Gibbs" <gibbs@FreeBSD.org> writes:
> > Someone who has yet to confess added -Werror to the global CFLAGS
> > (via /etc/make.conf) for one of our systems at work. Before I
> > figured out that this was the cause of builds failing, I hacked up
> > pam_passwdc to resolve the problem. This gets the module to
> > WARNS=3D2, but to go farther, the "logically const" issues with this
> > code will need to be sorted out.
> >
> > Is this change worth committing? Is this the best way to resolve
> > the strict aliasing issues in this code?
>=20
> I really don't like that sort of game. If you look at other PAM
> consumer code, you'll see that the common idiom is what Jilles
> suggested, i.e. use a temporary variable of the appropriate type.
>=20
> That being said, pam_passwdqc should probably be either updated or
> removed. The version we have is ten years old.
But it still works...
--O2g7+miYGsIKoR9l
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlADIkYACgkQKc512sD3afiC/gCfWZcu6Dfr8X1VKUFYUc5/7hKf
5dAAoK05ROMSoqFUnOvPhetqtlocTCTa
=lp0f
-----END PGP SIGNATURE-----
--O2g7+miYGsIKoR9l--
討論串 (同標題文章)
完整討論串 (本文為第 4 之 4 篇)：