Re: panic: incorrect npmc count
--Apple-Mail=_4EE97FF8-E5B3-43F3-960A-7DAA9D7602A3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=iso-8859-1
Le 9 mai 2012 =E0 16:30, Ryan Stone a =E9crit :
> On Wed, May 9, 2012 at 1:16 AM, Peter Jeremy <peter@rulingia.com> =
wrote:
>> [This may be a duplicate because I forgot to update my subscription
>> after changing address but I've also corrected a typo]
>>=20
>> (I've copied fabient@ because r233628 appears to have been the last
>> commit in this area).
>>=20
>> I've just updated a P4 test box from r232545 to r235127 and it now
>> panics during boot:
>> panic: [intel,202] incorrect npmc count 35
>> Looking at sys/dev/hwpmc/hmpmc_intel.c line 202, the expected
>> npmc count is 19.
>>=20
>> When I look at the actual code in pmc_intel_initialize():
>> pmc_mdep_alloc() initialises pmd_npmc to zero and then increments
>> it by SOFT_NPMCS (16) in pmc_soft_initialize().
>> pmc_tsc_initialize() then increments it by TSC_NPMCS (1)
>> pmc_p4_initialize() then increments it by P4_NPMCS (18)
>> This totals 35 (as per the panic message).
>>=20
>> Can someone explain the KASSERT() that expects 19 - it boils down to
>> KASSERT(0+16+1+18 =3D=3D 1+18, ...)
>> I gather not many people are running -current on a P4.
>>=20
>> --
>> Peter Jeremy
>=20
> That KASSERT is just out of date. The soft PMC support is quite new.
> I would just drop the KASSERT entirely; it really isn't adding any
> value.
Back from vacation.
Yes, as Ryan stated the KASSERT is out of date and i've missed
the update / removal with soft PMC.
Fixed with r235229.
Fabien
--Apple-Mail=_4EE97FF8-E5B3-43F3-960A-7DAA9D7602A3--
討論串 (同標題文章)