Re: The current libc/locale/toupper.c is mistaken

If you have a test case, I can commit it to the libc++ test suite.

David

On 10 May 2012, at 21:42, Kohji Okuno wrote:

> Hi Eric,
>=20
>> I'm left wondering how this was not caught by the libc++ test
>> suite. The current toupper.c shouldn't pass
>> =
http://llvm.org/svn/llvm-project/libcxx/trunk/test/localization/locales/lo=
cale.convenience/conversions/conversions.character/toupper.pass.cpp
>=20
> This test suite checks only popular characters.
> __mapupper_ext is used in case of special characters.
>=20
> For example, Turkish 'i' (0x0131) should convert 'I' (0x49).
>=20
> Regards,
> Kohji Okuno
>=20
>=20
>> Den 10/05/2012 kl. 12.03 skrev Dimitry Andric:
>>=20
>>> On 2012-05-10 11:02, Kohji Okuno wrote:
>>>> I think that libc/locale/toupper.c is mistaken.
>>>> Could you check it?
>>>>=20
>>>> @@ -51,7 +51,7 @@ ___toupper_l(c, l)
>>>> {
>>>>       size_t lim;
>>>>       FIX_LOCALE(l);
>>>> -       _RuneRange *rr =3D =
&XLOCALE_CTYPE(l)->runes->__maplower_ext;
>>>> +       _RuneRange *rr =3D =
&XLOCALE_CTYPE(l)->runes->__mapupper_ext;
>>>>       _RuneEntry *base, *re;
>>>>=20
>>>>       if (c < 0 || c =3D=3D EOF)
>>>=20
>>> Yes, this definitely looks like a copy/paste error, introduced here:
>>>=20
>>> =
http://svnweb.freebsd.org/base/head/lib/libc/locale/toupper.c?r1=3D165903&=
r2=3D227753
>>>=20
>>> I'll commit the fix tonight (CEST), if David isn't faster than me. =
:)
>>=20
>> I'm left wondering how this was not caught by the libc++ test suite. =
The current toupper.c shouldn't pass =
http://llvm.org/svn/llvm-project/libcxx/trunk/test/localization/locales/lo=
cale.convenience/conversions/conversions.character/toupper.pass.cpp
>>=20
>> Thanks,
>> Erik_______________________________________________
>> freebsd-current@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-current
>> To unsubscribe, send any mail to =
"freebsd-current-unsubscribe@freebsd.org"

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"