Re: [patch] turning devctl into a "multiple openable" device

On Wednesday, November 30, 2011 7:43:20 am Baptiste Daroussin wrote:
> Hi all,
> 
> With the help of cognet, I wrote a patch to turn devctl into a multiple openable
> device, that mean that it will allow to open /dev/devctl in multiple programs,
> for example hald and everythings that want to receive notification from the
> device won't need to depend on haveing devd running.
> 
> here is the patch: 
> http://people.freebsd.org/~bapt/devctl_multi_open.diff

Shouldn't devctl_queue_data_f() use the requested malloc() flags instead of
hardcoding M_NOWAIT?

Also, I know that it was an intentional design decisison by Warner to have
the multiplexing of devctl data done in userland via devd rather than in the
kernel.  (I think he envisioned devd providing a UNIX domain socket or some
such for other daemons to use to listen to events.)  Have you asked him about
this change?

-- 
John Baldwin
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"