Re: Dtrace: type mismatch in sys/kern/kern_sig.c

On 19 September 2011 19:24, Anton Yuzhaninov <citrin@citrin.ru> wrote:
> In the file sys/kern/kern_sig.c defined DTrace probe proc:::signal-discard
>
> SDT_PROBE_DEFINE(proc, kernel, , signal_discard, signal-discard);
> SDT_PROBE_ARGTYPE(proc, kernel, , signal_discard, 0, "struct thread *");
> SDT_PROBE_ARGTYPE(proc, kernel, , signal_discard, 1, "struct proc *");
> SDT_PROBE_ARGTYPE(proc, kernel, , signal_discard, 2, "int");
>
> Then latter this proble called as:
>
> SDT_PROBE(proc, kernel, , signal_discard, ps, td, sig, 0, 0 );
>
> type for var ps is struct sigacts* =! struct thread * (bug?)
> type for var td is struct thread * =! struct proc * (bug?)
> type for var sig is int == int (ok)
>
> To match solaris DTrace probe shuild called as:
>
> SDT_PROBE(proc, kernel, , signal_discard, td, p, sig, 0, 0 );
>

Yes, seems a typo there. Also conforms to the Solaris Dynamic Tracing Guide:
http://download.oracle.com/docs/cd/E19082-01/819-3620/gelse/index.html

(Also, td and p are somewhat different wrt. psinfo_t and lwpsinfo_t in Solaris).

-- 
wbr,
pluknet
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"