Re: panic: share -> excl @r224632
--fpc9xpxSwr8iiS8p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Aug 05, 2011 at 10:18:49AM +0200, Martin Matuska wrote:
> I agree to Kostik's approach, but I suggest implementing it in a
> separate function and also use for the unmount() part.
>=20
> Please review attached patch.
Since you are moving the fragment to a function, you may somewhat reduce
the code duplication by moving at least free() and return to the end
of function and jumping to it.
Also, after more looking at this, I think now that the check for VI_DOOMED
is not needed, due to relookup and comparision of vp and vp1.
--fpc9xpxSwr8iiS8p
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEARECAAYFAk47qT8ACgkQC3+MBN1Mb4jmtgCgtCob+OYGFugy+XXWnc4Ot1LN
DHQAoL/xOsJYQUZWntIacNHOwFdFFdbw
=Ol9R
-----END PGP SIGNATURE-----
--fpc9xpxSwr8iiS8p--
討論串 (同標題文章)
完整討論串 (本文為第 5 之 6 篇)：