Re: [CFT] Sierra Wireless HSPA+ USB modem

On Wed, Jul 6, 2011 at 9:19 AM, Hans Petter Selasky <hselasky@c2i.net> wrote:
>>
>> Hi,
>>
>> I'm going to review and import your driver.
>>
>> --HPS
>
> Hi,
>
> The intial patch had some bad code and didn't compile on 9-current. I've tried
> to clean it up. Please test and report back if I didn't break anything.
>
> http://hselasky.homeunix.org:8192/usie_for_FreeBSD_9_current.patch
>
> --HPS
>
Hello,

Thanks for the patch.

if_usie.c
241	if (usbd_lookup_id_by_uaa(usie_devs, sizeof(usie_devs), uaa) != 0)
242		return;			/* no device match */

It should return non-zero on success, but somehow this caused the
process to exit, and modem stayed being a CD-ROM.

The compiler complained about uninitialized int
if_usie.c: 1484
-	uint8_t pad;
+	uint8_t pad = 0;

Otherwise it worked fine.

AK
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"