Re: gnu/175985: [PATCH] Improve send-pr

The following reply was made to PR gnu/175985; it has been noted by GNATS.

From: Christoph Mallon <christoph.mallon@gmx.de>
To: Eitan Adler <eadler@freebsd.org>
Cc: bug-followup <bug-followup@freebsd.org>
Subject: Re: gnu/175985: [PATCH] Improve send-pr
Date: Sat, 16 Feb 2013 08:04:16 +0100

 On 15.02.2013 19:25, Eitan Adler wrote:
 > On 9 February 2013 08:50, Christoph Mallon <christoph.mallon@gmx.de> wrote:
 > 
 > I have not yet looked at the code.
 > 
 >>> Description:
 >> - Do not delete lines starting with Subject:.
 >>   They are most probably part of a attached git patch.
 > 
 > This is probably fine, but I am curious why they were removed in the
 > past.  How does GNATS actually treat the subject line?

 There is no Subject line in the PR template presented to the user.
 After the user finishes filling out the PR template, send-pr adds a Subject line with a copy of the Synopsis.
 I guess, GNATS shows the Subject just like any other field.
 send-pr ensures, that Subject and Synopsis are the same (Have a look at some random PRs).

 >> - Recognize an empty file as a not filled out PR, too.
 > 
 > This is fine with me.
 >> - Allow attaching files via -- followed by file names.
 > 
 > This is fine with me.

 I also have another patch, which adds a dummy file after each file.
 GNATS does not recognize every other file.
 This works around the problem.
 The proper solution would be to correct the problem in GNATS.

 	Christoph
_______________________________________________
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"