Re: bin/113518: [patch] make(1): Prevent execution when command

The following reply was made to PR bin/113518; it has been noted by GNATS.

From: Jilles Tjoelker <jilles@stack.nl>
To: bug-followup@FreeBSD.org, ed@fxq.nl
Cc: sjg@FreeBSD.org
Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a
 comment
Date: Sun, 4 Nov 2012 13:11:58 +0100

 In PR bin/113518:
 > [patch to teach make about the shell's comment character]

 The first thing here is whether there are actually real-life Makefiles
 containing shell commands consisting only of comments. I only find a
 few in /usr/ports/Mk:

 jilles@jaguar /usr/ports/Mk% grep $'^[ \t]\\+#' *
 bsd.gecko.mk:   # XXX: make sure bsdtar(1) corrected symlinks
 bsd.kde4.mk:  # Check that the component is valid.
 bsd.kde4.mk:   # Skip meta-components (e.g., kdeprefix).
 bsd.kde4.mk:    # Check if a dependency type is explicitly requested.
 bsd.kde4.mk:    # If no dependency type is set, default to full dependency.
 bsd.kde4.mk:    # Set real dependencies.

 Likewise, there are only very few in src/**/Makefile* .

 It is unlikely that skipping the shell for these will give significant
 performance benefits.

 Secondly, I don't think such new features should be added to make(1)
 when it is planned to replace it with bmake (sjg@ cc'ed). Also, bmake
 generally knows less about the shell than make(1) does so it does not
 seem to fit in to add it to bmake.

 -- 
 Jilles Tjoelker
_______________________________________________
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"