Re: bin/143017: watch(8): fatal: cannot attach to tty
The following reply was made to PR bin/143017; it has been noted by GNATS.
From: Ed Schouten <ed@80386.nl>
To: Mark Johnston <markjdb@gmail.com>
Cc: bug-followup@freebsd.org, dummy@smtp.ru
Subject: Re: bin/143017: watch(8): fatal: cannot attach to tty
Date: Mon, 12 Mar 2012 22:27:25 +0100
--gTY1JhLGodeuSBqf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
* Mark Johnston <markjdb@gmail.com>, 20120312 22:17:
> Oh, I was referring to the -i flag; my comment was misleading, sorry.
> opt_interactive (or something similar) is still needed in order for
> watch(8) to work properly when writing output to a file, no?
Sure, but in that case you can simply use isatty() to distinguish the
special treatment. What I mean is that you can only call watch(8) by
passing the TTY used on the command line.
Also I see you've simplified the code that dynamically scales the input
buffer size. Though I think that's a good idea, I do think we should
increase BUF_SIZE to something higher. Setting it to 4 KB or something
shouldn't harm, right?
--=20
Ed Schouten <ed@80386.nl>
WWW: http://80386.nl/
--gTY1JhLGodeuSBqf
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)
iQIcBAEBAgAGBQJPXmo9AAoJEG5e2P40kaK7OzYP/19abRoyvfYM7KbPpV88P/B5
oOOzD4xnfPzdHy5HTkoDz8UyS0nwZEhxLwVOHRxyOhmr+6EJ5Wc+aU2B/kMWUWTX
KQMVzvND0jq867MNv/p/tQp0PvQBfebG/jp/uNcHV8KtNPRMneEKR6o02wDaj2kQ
Y+e2QVe0H+SolAJHKxOpy5L5p/A282bL7Tjc6yGq1RTh3OF22jPyRcdmB3Dchgwh
OjmDzu2F2g8+K0vGNiDBI1q8ZzSQ1OHy42GkDkRStakPh4yCyT430B8sRr2DOhYw
U3FCRx15qpfFXPsh+rYH3JaqKLw5K+ewWDpXw61eNFz2FQuavwiqi1gM8+KqWeDJ
u+PchWtAScQ+Y4oJUpmJgia/GHCncvWaQ0K0aG35PuBagnDS0CzXz5qHhEI5rqiA
ENQPeelwz/BWnvFfnkZdIDYA5rwndlrDGw7lXjGLsyH4PYVegtmqXcHUVgYAEpnG
D1mElDHCuc2RY5z3s3rt/T5Z6W3j+awhwLxsc0V7wrDKp627Ly23v6pqnmk1dw4m
SDZUPj39R1eRHE82+dtX4fKWLtAl2k8P2rPz1+lzre82fqDzk7hHw93iuDW0PpvL
sU5Uy4UxHGQsIaaGadiiJEfVeMMFJoQUVrCpymz3VJt6h4Ro7+MC1wbjcyjnddLu
3+ieINfse6iLxIE760I/
=qWD5
-----END PGP SIGNATURE-----
--gTY1JhLGodeuSBqf--
_______________________________________________
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"
討論串 (同標題文章)
完整討論串 (本文為第 5 之 6 篇):