Re: setenv cleanup of usr.sbin/resident
On 4/22/05, Joe Talbott <josepht@cstone.net> wrote:
> On Thu, Apr 21, 2005 at 08:42:01PM +0200, liamfoy@sepulcrum.org wrote:
> >
> > Joe Talbott <jtalbott@xenno.com> wrote on 21.04.2005, 16:22:45:
> > > Here's a patch to check the return value of setenv () in
> > > usr.sbin/resident/resident.c.
> > >
> > > Joe
> >
> > Hey Joe,
> >
> > This is ok except we dont role our own err/warn messages. Could
> > you replace the fprintf() and strerror() with warn()? :-)
> >
>
> Oh and here's the patch. Doh!
>
> Joe
>
Ok, I will commit this tonight. However, when submitting patches always
make sure they conform to style(9).
--
Liam J. Foy
DragonFly BSD Committer
http://www.bsd-systems.co.uk
討論串 (同標題文章)
完整討論串 (本文為第 5 之 6 篇)：