Re: rl(4) TX_UNDERRUN fix
--nextPart11317129.RUhf9U3gSy
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Monday 21 February 2005 19:45, Joerg Sonnenberger wrote:
> Hi all,
> please test http://leaf.dragonflybsd.org/~joerg/if_rl.c.diff
> with any kind of rl(4). This patch is a more aggressive version
> of the recently commited patch in FreeBSD 5/6, the version
> orginaly proposed in kern/61448.
>
> It shouldn't negatively impact performance or stability.
I choose the less aggressive one for a (couple of) reason(s):
- not all chips can RL_TXCFG_CLRABRT some even forbid it in the specs.
- the ifp->if_opackets++ just isn't right. You should only increase it if =
you=20
get RL_TXSTAT_TX_OK.
- removing the reset/init cycle *might* be a good thing, but only if you c=
an=20
assure that it doesn't break the older chips. Some notes in the specs=20
suggest different.
=2D-=20
/"\ Best regards, | mlaier@freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier@EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
--nextPart11317129.RUhf9U3gSy
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)
iD8DBQBCGjjwXyyEoT62BG0RAkdjAJsEFZj4eyWQ1PtojI84PuFfvE8lJwCfZd57
da7AR+AYWtT+T3+SDJS6pUw=
=zwT7
-----END PGP SIGNATURE-----
--nextPart11317129.RUhf9U3gSy--
討論串 (同標題文章)