Re: msgs WARNS6 cleanup
On Mon, 17 Jan 2005 11:22:02 -0500, Larry Lansing <lansil@fuzzynerd.com> wrote:
> Index: Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/msgs/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- Makefile 17 Jun 2003 04:29:29 -0000 1.2
> +++ Makefile 17 Jan 2005 16:15:14 -0000
> @@ -3,6 +3,7 @@
> # $DragonFly: src/usr.bin/msgs/Makefile,v 1.2 2003/06/17 04:29:29 dillon Exp $
>
> PROG= msgs
> +WARNS?= 6
> DPADD= ${LIBTERMCAP}
> LDADD= -ltermcap
>
> Index: msgs.c
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/msgs/msgs.c,v
> retrieving revision 1.3
> diff -u -r1.3 msgs.c
> --- msgs.c 4 Oct 2003 20:36:49 -0000 1.3
> +++ msgs.c 17 Jan 2005 16:20:53 -0000
> @@ -101,7 +101,7 @@
>
> FILE *msgsrc;
> FILE *newmsg;
> -char *sep = "-";
> +const char *sep = "-";
> char inbuf[BUFSIZ];
> char fname[MAXPATHLEN];
> char cmdbuf[MAXPATHLEN + MAXPATHLEN];
> @@ -142,7 +142,7 @@
> jmp_buf tstpbuf;
>
> -void ask(char *);
> +void ask(const char *);
> void gfrsub(FILE *);
> int linecnt(FILE *);
> int next(char *);
> @@ -660,7 +660,7 @@
> }
>
> void
> -onintr(int unused)
> +onintr(int unused __unused)
> {
> signal(SIGINT, onintr);
> if (mailing)
> @@ -685,7 +685,7 @@
> * We have just gotten a susp. Suspend and prepare to resume.
> */
> void
> -onsusp(int unused)
> +onsusp(int unused __unused)
> {
> signal(SIGTSTP, SIG_DFL);
> sigsetmask(0);
> @@ -719,7 +719,7 @@
> }
>
> void
> -ask(char *prompt)
> +ask(const char *prompt)
> {
> char inch;
> int n, cmsg, fd;
>
It looks like LI, Xin is doing a lot of the same kind of clean up work in fbsd.
http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.bin/msgs/msgs.c.diff?r1=1.26&r2=1.27
--
-David
Steven David Rhodus
<drhodus@machdep.com>
討論串 (同標題文章)