Re: patch for netinet crash
:There is a race condition that seems to be affecting only me, and apparently only when I
:run puTTY as a client. Here's a patch that fixes it, in addition to the one Matt
:submitted.
:
:===================================================================
:RCS file: /home/dcvs/src/sys/netinet/ip_input.c,v
:retrieving revision 1.43
:diff -u -r1.43 ip_input.c
:--- ip_input.c 29 Dec 2004 03:26:42 -0000 1.43
:+++ ip_input.c 5 Jan 2005 21:22:40 -0000
:@@ -742,6 +742,8 @@
: */
: if (m->m_pkthdr.rcvif->if_flags & IFF_BROADCAST) {
: TAILQ_FOREACH(ifa, &m->m_pkthdr.rcvif->if_addrhead, ifa_link) {
:+ if (ifa == NULL)
:+ continue;
: if (ifa->ifa_addr == NULL) /* shutdown/startup race */
: continue;
: if (ifa->ifa_addr->sa_family != AF_INET)
:
That's impossible, ifa is the iteration variable and it should not
be possible for it to be NULL. Could you take it out and see if your
box continues to crash get a crash dump?
(If you need a leaf account to upload crash dumps too send me a private
email with your ssh public key).
-Matt
Matthew Dillon
<dillon@backplane.com>
討論串 (同標題文章)