Cleanup Base: fetch
Hi,
This is the first time I submit anything for anything ever so please
let me know if I have done something wrong or missed something or
anything that I should know with regards to submitting patches. I have
also added my name to the list of modules being worked on, on the
wiki. How does the removal of my name work from the busy applications
list? Should I do it once the patch has been successful? Also who will
cross out the fetch command from the list of applications that still
need to be patched from the wiki if this patch is successful?
I hope that you can help me in any errors that I have made in both the
patches as well as the whole process of sending patches so that I may
get up to speed with developing for DragonFly BSD as fast as possible
and stop wasting time.
Sorry for any inconvenience I may have caused if any. If you can point
me to any more documentation that might help, please do so.
Thanks
Jeandre du Toit
/usr/src/usr.bin/fetch/fetch.c
--- fetch.c.orig 2005-01-04 22:56:52.000000000 +0200
+++ fetch.c 2005-01-04 23:05:51.000000000 +0200
@@ -331,8 +331,8 @@
}
/* if no scheme was specified, take a guess */
- if (!*url->scheme) {
- if (!*url->host)
+ if (*url->scheme == '\0') {
+ if (*url->host == '\0')
strcpy(url->scheme, SCHEME_FILE);
else if (strncasecmp(url->host, "ftp.", 4) == 0)
strcpy(url->scheme, SCHEME_FTP);
/usr/src/usr.bin/fetch/Makefile
--- Makefile.orig 2005-01-04 23:24:34.000000000 +0200
+++ Makefile 2005-01-04 23:24:27.000000000 +0200
@@ -2,7 +2,7 @@
# $DragonFly: src/usr.bin/fetch/Makefile,v 1.4 2004/01/31 06:56:43 dillon Exp $
PROG= fetch
-WARNS?= 2
+WARNS?= 6
DPADD= ${LIBFETCH}
LDADD= -lfetch
.if !defined(NOCRYPT) && !defined(NO_OPENSSL)
討論串 (同標題文章)
完整討論串 (本文為第 1 之 12 篇)：