Re: PF test for inclusion
--nextPart1430576.W4Q3rNxDVN
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Thursday 16 September 2004 02:16, Simon 'corecode' Schubert wrote:
> general opinion (sometimes after thinking a bit longer) about this was
> to get rid of the needed m_tag allocation each time. pkthdr can be
> easily extended as m_buf is much larger anyways and this space is not
> used most of the time.
And how many packets really use tags (in the non-ALTQ case)? ... anyway
> > Anyway, nice to see this happening.
>
> yea, finally :)
>
> >> Please test it and provide me with any feedback.
> >
> > Take a look at:
> > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/contrib/pf/net/
> > pf.c.diff?r1=3D1.18&r2=3D1.19&f=3Dh
>
> this doesn't apply to us as we're using freebsd native byte order for
> the headers, not the openbsd one. this is why we can use ip->ip_len
> directly. arguable if using len is a worthwile speedup :)
ip->ip_len is not the right length for in_pseudo() in this piece of code. I=
n=20
tcp_input() (where this piece of code is derived from) ip->ip_len is alread=
y=20
subtrackted with the ip header length ...
> > and maybe
> > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/contrib/pf/net/
> > pf_if.c.diff?r1=3D1.5&r2=3D1.6&f=3Dh
>
> what's that exactly? do you think that's also a problem with
> dragonfly/freebsd-stable's ppp? It seems that this is more a problem of
> ppp. Do you think that this can be fixed in ppp? But as a preliminary
> solution definitively worth consideration.
The problem is that there seem to be things out there in the wild, that rel=
y=20
on the IPCP address sticking around ... seems to be broken by design, but i=
f=20
you can fix ppp w/o breaking something else - please let me know. In any ca=
se=20
this (tries to) fix the symptom ...
> thanks for your support!
>
> >> Time to commit: Sunday
>
> oh btw: joerg, how do you intend pf to be updated later? without a
> vendor tag, i can imagine that creating + merging diffs from upstream
> could be a bitch.
Yes ... good point.
=2D-=20
/"\ Best regards, | mlaier@freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier@EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
--nextPart1430576.W4Q3rNxDVN
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQBBSOGLXyyEoT62BG0RAosLAJ43iPKA4lqSBk/4ctWQx6bDK9M10QCfd85r
6WQ1KFVrAGV406+Sz/Q17ZY=
=hZzO
-----END PGP SIGNATURE-----
--nextPart1430576.W4Q3rNxDVN--
討論串 (同標題文章)
完整討論串 (本文為第 4 之 6 篇)：