Re: bin/sh/mksyntax.c has wrong error handling [patch]
-On [20040722 21:52], Douwe Kiela (virtus@wanadoo.nl) wrote:
>bin/sh/mksyntax.c contains call to the perror() function, while
>sh has its own error function, that is used everywhere in the code,
>and is define in error.c, namely error(). For code consistency mksyntax.c
>should also be made to use this function, here is a patch:
Not applied.
mksyntax.c is a build time tool used to generate syntax.[ch].
In effect, error() from error.c is a wrapper function which calls
exverror(), which is a specialised error function that also does interrupt
clearing, tracing, flushing, and exception handling.
Thus for mksyntax.c perror() is absolutely valid and no change is needed.
--
Jeroen Ruigrok van der Werven <asmodai(at)wxs.nl> / asmodai / kita no mono
Free Tibet! http://www.savetibet.org/ | http://www.tibet.nu/
http://www.tendra.org/ | http://diary.in-nomine.org/
See with your eyes, hear with your ears. Nothing is hidden.
討論串 (同標題文章)