Re: [PATCH] rand.c updates from FreeBSD RELENG_5
:Oh, and if you check revision 1.15 of the FreeBSD rand.c code (where I
:got this), you will notice I removed the '#include "namespace.h"' and
:'#include "un-namespace.h"' lines. They wrapped around the headers to
:make them use different functions. This doesn't seem to have any
:negative effects with the code I have, but it'd be nice if someone who
:knows more can comment. It'd be easy to just copy those files if need
:be and re-add the lines.
:
:If this is viable for a commit, I would appreciate it. If not, send it
:back to me and I'll make the necessary changes.
:
:Thanks again,
:Mike
It looks pretty good. Hiten had some minor comments about retaining
the $ cvs tags, but that isn't something you actually need to worry
about since either Hiten or I will add them back in when we commit
now that we know they are missing.
I have one comment, and that is that the use of /dev/random has
created lots of unexpected problems in FreeBSD which they have
hacked around. I think we should simply use /dev/urandom here,
which is guarenteed not to block and will certainly produce a
random enough seed for rand's tiny little seed.
-Matt
討論串 (同標題文章)
完整討論串 (本文為第 4 之 18 篇)：