Re: top io patch
--0016e64f829c96408304afa43111
Content-Type: text/plain; charset=ISO-8859-1
Hi Pratyush,
It didn't apply cleanly in master:
Patching file usr.bin/top/m_dragonfly.c using Plan A...
Hunk #1 succeeded at 63.
Hunk #2 succeeded at 85.
Hunk #3 failed at 98.
Hunk #4 succeeded at 178 (offset -1 lines).
Hunk #5 failed at 198.
Hunk #6 failed at 210.
Hunk #7 failed at 222.
Hunk #8 succeeded at 348 (offset 2 lines).
Hunk #9 failed at 390.
Hunk #10 succeeded at 473 (offset -2 lines).
Hunk #11 succeeded at 554 (offset 2 lines).
Hunk #12 succeeded at 560 (offset -2 lines).
Hunk #13 succeeded at 606 (offset 2 lines).
Hunk #14 succeeded at 617 (offset -2 lines).
Hunk #15 succeeded at 670 (offset 2 lines).
Hunk #16 failed at 747.
Hunk #17 succeeded at 797 (offset -4 lines).
Hunk #18 succeeded at 1077 (offset 31 lines).
Hunk #19 succeeded at 1076 (offset -4 lines).
6 out of 19 hunks failed--saving rejects to usr.bin/top/m_dragonfly.c.rej
done
Can you please fix it?
Cheers,
Antonio Huete
2011/10/14 Pratyush Kshirsagar <pratyush.kshirsagar@gmail.com>
> Hello,
> Here is the top io patch attached.
> This patch is just for testing purpose.
> I have made some changes to PRES print and sorting stuff.
> As, I was testing this on my old system, cause its graphical and gives me
> some good read and write results while fire-fox is running.
> I talked on IRC and Alex told me that the IVCSW (In voluntary context
> switches) values are not stored properly but on my system I always see the
> IVCSW values zero both with the values from the struct kp_ru and kp_cru i.e.
> I tried to check the values of process resource usage and childs resource
> usage and the IVCSW is allways zero. May be their are no involuntary context
> switches on my system, may be the processes are kind enough to utilise cpu
> in bounds.
> Also, I added a function to sort the reads which is not sorting the
> processes properly, although the logic is same the way with other sort
> ORDERKEY's.
>
> Please test this patch with the top -m io command and give me some
> suggestions on it.
>
> Note: This patch is just to get some feedback. The only things missing in
> this patch is sorting the output depending on write, total io, vcsw, ivcsw
> and faults.
>
> - Pratyush Kshirsagar.
>
--0016e64f829c96408304afa43111
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Hi Pratyush,<div><br></div><div>It didn't apply cleanly in master:</div=
><div><br></div><div><div><div>Patching file usr.bin/top/m_dragonfly.c usin=
g Plan A...</div><div>Hunk #1 succeeded at 63.</div><div>Hunk #2 succeeded =
at 85.</div>
<div>Hunk #3 failed at 98.</div><div>Hunk #4 succeeded at 178 (offset -1 li=
nes).</div><div>Hunk #5 failed at 198.</div><div>Hunk #6 failed at 210.</di=
v><div>Hunk #7 failed at 222.</div><div>Hunk #8 succeeded at 348 (offset 2 =
lines).</div>
<div>Hunk #9 failed at 390.</div><div>Hunk #10 succeeded at 473 (offset -2 =
lines).</div><div>Hunk #11 succeeded at 554 (offset 2 lines).</div><div>Hun=
k #12 succeeded at 560 (offset -2 lines).</div><div>Hunk #13 succeeded at 6=
06 (offset 2 lines).</div>
<div>Hunk #14 succeeded at 617 (offset -2 lines).</div><div>Hunk #15 succee=
ded at 670 (offset 2 lines).</div><div>Hunk #16 failed at 747.</div><div>Hu=
nk #17 succeeded at 797 (offset -4 lines).</div><div>Hunk #18 succeeded at =
1077 (offset 31 lines).</div>
<div>Hunk #19 succeeded at 1076 (offset -4 lines).</div><div>6 out of 19 hu=
nks failed--saving rejects to usr.bin/top/m_dragonfly.c.rej</div><div>done<=
/div></div><div><br></div><div>Can you please fix it?</div><div><br></div>
<div>Cheers,</div><div>Antonio Huete</div><br><div class=3D"gmail_quote">20=
11/10/14 Pratyush Kshirsagar <span dir=3D"ltr"><<a href=3D"mailto:pratyu=
sh.kshirsagar@gmail.com">pratyush.kshirsagar@gmail.com</a>></span><br><b=
lockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px =
#ccc solid;padding-left:1ex;">
Hello,<br>Here is the top io patch attached.<br>This patch is just for test=
ing purpose.<br>I have made some changes to PRES print and sorting stuff.<b=
r>As, I was testing this on my old system, cause its graphical and gives me=
some good read and write results while fire-fox is running.<br>
I talked on IRC and Alex told me that the IVCSW=A0 (In voluntary context sw=
itches) values are not stored properly but on my system I always see the IV=
CSW values zero both with the values from the struct kp_ru and kp_cru i.e. =
I tried to check the values of process resource usage and childs resource u=
sage and the IVCSW is allways zero. May be their are no involuntary context=
switches on my system, may be the processes are kind enough to utilise cpu=
in bounds.<br>
Also, I added a function to sort the reads which is not sorting the process=
es properly, although the logic is same the way with other sort ORDERKEY=
9;s.<br><br>Please test this patch with the top -m io command and give me s=
ome suggestions on it.<br>
<br>Note: This patch is just to get some feedback. The only things missing =
in this patch is sorting the output depending on write, total io, vcsw, ivc=
sw and faults.<br><font color=3D"#888888"><br>- Pratyush Kshirsagar.<br>
</font></blockquote></div><br></div>
--0016e64f829c96408304afa43111--
討論串 (同標題文章)
完整討論串 (本文為第 2 之 2 篇)：