Re: trap_pfault growstack vs vm_fault ordering?
:Hi,
:
:Currently trap_pfault for each of the three DragonFly platforms
:attempts to grow the stack region (via growstack()) before attempting
:vm_fault. For any faults not in stack growth regions, this will result
:in lots of work (3 crit_enter/crit_exit pairs, a number of zone
:allocations). Would it be worth moving the stack growth call into
:vm_fault, after the vm_map_lookup call?
You're absolutely right, plus your patch allows us to get rid of
some machine-dependend code too.
I'll incorporate it, thanks!
-Matt
討論串 (同標題文章)