Re: sasc re-write
On Mon, Jan 17, 2005 at 09:24:53AM +0100, Simon 'corecode' Schubert wrote:
> hey, just a few comments
>
....
And a nit...
> >+ val = strtol(str, &ep, 10);
> >+ if (errno)
> >+ err(1, "strtol failed: %s", str);
I'd not attempt to use errno as a boolean, I'd do:
if (errno != 0)
...
Especially as later on you do:
>+ if (ioctl(fd, asc_setting, &asc_value) < 0)
> you don't reset errno to 0, so this might be not working. reading the
> man page it might be needed :/
Indeed it would be.
- Diane.
討論串 (同標題文章)
完整討論串 (本文為第 3 之 10 篇)：