Re: List of patches
"David Rhodus" <sdrhodus@gmail.com> schreef:
> On Sun, 7 Nov 2004 18:35:46 +0100, Douwe Kiela <virtus@wanadoo.nl>
> wrote:
>> "David Rhodus" <sdrhodus@gmail.com> schreef
>>> On Sun, 07 Nov 2004 16:23:31 +0000, Liam Foy <liamfoy@sepulcrum.org>
>>> wrote:
>>>> Douwe Kiela has a list of patches at:
>>>> http://leaf.dragonflybsd.org/~virtus/trivial/.
>>>> They all look completely fine to me. I will commit them within an
>>>> hour or so if no objections are recieved.
>>> Was there an style aggrement made on removing all of these void's?
>> Yes, this has been discussed on submit@ a while ago.. Both Joerg
>> and Matt said they could be removed, their email can respectively
>> be found here:
>> http://leaf.dragonflybsd.org/mailarchive/submit/2004-07/msg00152.html
>> and here:
>> http://leaf.dragonflybsd.org/mailarchive/submit/2004-07/msg00173.html
> Makes sense now after I've woken up completely. Removing them also
> adds better code consistency to the project as a whole.
Exactly! This should be changed all over the code really, but right now
every now and then it gets cleaned up. Perhaps if I have time I'll write up
a shellscript to remove all (void) casts in the tree (where they should be
removed, of course) and provide a patch. The problem is the inconsistency in
the way they are casted.. I wouldn't want to risk also removing the (void)
argument from e.g. usage(void).. I'll probably be able to avoid that
though..
Regards,
Douwe
討論串 (同標題文章)
完整討論串 (本文為第 5 之 11 篇)：