Re: ktr port from FreeBSD
On Fri, Sep 03, 2004 at 09:42:29AM -0700, Matthew Dillon wrote:
> Also, the FreeBSD code probably used mutexes where you are using a token.
> For ktr_tracepoint() to be callable from 'anywhere' you can't use a token
> there but must instead convert the code to use a critical section and
> per-cpu arrays.
I've been talking about this and other parts of the patch with Eirik
already and he/we will convert it to full per-cpu structures in a second
instance.
> Also, 1024 entries is probably not nearly enough for a tracepoint
> utility to be useful. We'd need a lot of entries... a million or more,
> for it to be really useful, which implies dynamically allocating the
> array at boot time rather then declaring it static.
That will happen together with above change.
Joerg
>
> -Matt
> Matthew Dillon
> <dillon@backplane.com>
討論串 (同標題文章)