Re: git: pmap: Warning -> Debug
Matthew Dillon wrote:
> : pmap: Warning -> Debug
> :
> : This message does not concern the system administrator,
> : try not to get them worried for no reason.
> :
> :Summary of changes:
> : sys/platform/pc32/i386/pmap.c | 2 +-
>
> It can just be removed now, it's proven that the case occurs.
That's what I set out to do, but thought I'd play it safe for now.
FWIW, this is not the first time someone on irc asked about those "make
sure this case is actually hit" kprintfs. I think it would be good
practice to label them "Debug:" instead of "Warning:" in the future. The
latter implies that the administrator should do something, which is
definitely not the case.
(I've just noticed I commented on that exact warning when you committed
it a few weeks ago and you suggested changing the message. My memory for
these things is terrible :-)
Aggelos
討論串 (同標題文章)