Re: git: kernel - Fix some rare pmap races in i386 and x86_64.

看板DFBSD_commit作者時間16年前 (2010/02/23 03:32), 編輯推噓0(000)
留言0則, 0人參與, 最新討論串2/3 (看更多)
Matthew Dillon wrote: [...] > * Interlock the pmap structure when invalidating pages using a bit > in the pm_active field. > > Check for the interlock in swtch.s when switching into threads > and print a nice warning if it occurs. + if (pmap->pm_active & CPUMASK_LOCK) { + kprintf("Warning: pmap_interlock %08x\n", pmap->pm_active); Err, this warning is totally meaningless to an administrator or pretty much anybody who didn't read this patch. Wouldn't something like kprintf("Diagnostic: pmap_interlock %08x. Please report this!\n", pmap->pm_active) or even kprintf("Wow. pmap_interlock %08x. Please report this!\n", pmap->pm_active) be more useful to both sides? Aggelos
文章代碼(AID): #1BWjkr-B (DFBSD_commit)
文章代碼(AID): #1BWjkr-B (DFBSD_commit)