Re: cvs commit: src/sys/kern kern_slaballoc.c
On Mon, Mar 28, 2005 at 09:48:40AM -0800, Matthew Dillon wrote:
>
> :
> :On Mon, Mar 28, 2005 at 05:13:33PM -0000, Andreas Hauser wrote:
> :> > Remove redundant panic.
> :>
> :> Joerg,
> :>
> :> can you elaborate a bit more ?
> :
> :This simply removed some dead code. The conditional was always false,
> :because it was already checked a few lines before.
> :
> :Joerg
>
> Actually not quite true. The first condition requires that both bits
> be zero. The second requires only that one bit be 0... which means
> that you can't remove the second one. You might be able to remove
> the first one.
I should sleep more. Matt, what do you think about truely separating the
M_NULLOK and M_RNOWAIT flags? Currently M_RNOWAIT implies M_NULLOK and
since the flags are created by sys/malloc.h anyway, we could
include M_NULLOK in the M_RNOWAIT cases.
Joerg
討論串 (同標題文章)
完整討論串 (本文為第 5 之 9 篇)：