Re: cvs commit: src/sys/kern kern_lockf.c
On Wed, 2005-03-02 at 22:56 -0800, Matthew Dillon wrote:
> dillon 2005/03/02 22:56:41 PST
>
> DragonFly src repository
>
> Modified files:
> sys/kern kern_lockf.c
> Log:
> off_t is a signed value. The last commit caused the kernel to fail with
> a end < start panic.
>
> Revision Changes Path
> 1.23 +1 -1 src/sys/kern/kern_lockf.c
>
>
> http://www.dragonflybsd.org/cvsweb/src/sys/kern/kern_lockf.c.diff?r1=1.22&r2=1.23&f=u
>
This was found by me while porting this change over to FreeBSD. In
FreeBSD, there was a case where
start = 0xffffffff
end = 0x7fffffff
Thus, my FreeBSD 6-CURRENT kernel was panicking with start > end.
Joerg suggested that this might be a macro error. Patching the tree with
ULLONG_MAX seemed to fix the error, but now I'm getting it again. I'll
switch the commit back in my Perforce branch and re-report. This is very
odd.
--Devon
討論串 (同標題文章)
完整討論串 (本文為第 5 之 8 篇)：