Re: [issue1863] Implement 'hammer volume-list' subcommand
On 10/20/2010 02:00 AM, Sascha Wildner wrote:
> On 10/19/2010 23:22, Aggelos Economopoulos wrote:
>> On 10/19/2010 10:59 PM, Stathis Kamperis (via DragonFly issue tracker)
>> wrote:
>>>
>>> Stathis Kamperis<ekamperi@gmail.com> added the comment:
>>>
>>> New patch, same url:
>>> http://stathisk.ath.cx/0001-HAMMER-Implement-volume-list-command.patch
>>
>> Can you explain why you use the 0001- prefix if you're going to use the
>> same url over and over again? It's just extra pain for us to rename your
>> patches, which is something I did, so now I can do the following, in
>> order to only review your changes relative to the last patch.
>> [...]
>
> fetch -o ...
Yes, that is the renaming I was refering to. The fact that it is easy
to do does not address the problems I pointed out, namely that it is
pointless to have a serial counter prefix and not increment it.
Addditionally, rewriting the patch means that it is the reviewers who
need to bother with keeping history (which, as demonstrated, *is*
useful) and of course I can no longer refer unambiguously to version 1
of the patch (My local numbering after the renames is 0-2. What's yours?).
Aggelos
討論串 (同標題文章)
完整討論串 (本文為第 14 之 17 篇)：