Re: Apple Trackpad driver

--001a1133a922d4a58604f129b86b
Content-Type: text/plain; charset=UTF-8

Hans,

Thanks for you take care of it and commit it! I found two problems:

1. The selection is not expected when selection with 2 fingers sometimes.
2.  Unexpected scrolling when Click with 2 fingers.

This patch can fix that. The var "n" modify to "ntouch"  seems to be
necessary.

Cheers,
Huang Wen Hui

2014-01-29 Hans Petter Selasky <hps@bitfrost.no>

> On 01/29/14 09:49, Lundberg, Johannes wrote:
>
>> Hi
>>
>> I tested the driver on a 2012 Macbook Air 11" and it works great! Good
>> job!
>>
>> Is there a way to disable click-by-touch? I always preferred clicking with
>> the physical button that is built in to the pad.
>>
>>
> Hi,
>
> I've added an "#if 0" around the 1 finger tap code until further. Maybe
> this feature can be tunable?
>
> I fixed the code style, added some range checks and cleared some buffer
> issues.
>
> When you assign a signed value to an unsigned variable, you should range
> check it, because the sign might cause an overflow when you use it later on.
>
> int8_t x = -1;
>
> uint32_t t = x;
>
> "t" is now "0xffffffffU" and not "255".
>
> Tested the code on my MacBookPro. Hope I didn't break anything. If so,
> send a patch to freebsd-usb.
>
> http://svnweb.freebsd.org/changeset/base/261260
>
> To get the touchpad working with Xorg, I needed to re-compile HALD with
> the attached patch.
>
> kwm: Can you get the attached patch into ports?
>
> Auto-loading of wsp via devd will be done later. Simply need to
> re-generate usb.conf in /etc ...
>
> --HPS
>
>

--001a1133a922d4a58604f129b86b
Content-Type: text/plain; charset=US-ASCII; name="wsp.diff"
Content-Disposition: attachment; filename="wsp.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_hr1lutxl1

LS0tIHdzcC5jLm9yaWcJMjAxNC0wMS0zMCAwODoxNDoyNi4wMDAwMDAwMDAgKzA4MDAKKysrIHdz
cC5jCTIwMTQtMDEtMzAgMTM6NDk6NTkuMDAwMDAwMDAwICswODAwCkBAIC05NTcsOCArOTU3LDgg
QEAKIAkJaWYgKGgtPnEyID09IDQpCiAJCQlzYy0+aW50cl9jb3VudCsrOwogCi0JCWlmIChzYy0+
bnRhcHMgPCBuKSB7Ci0JCQlzd2l0Y2ggKG4pIHsKKwkJaWYgKHNjLT5udGFwcyA8IG50b3VjaCkg
eworCQkJc3dpdGNoIChudG91Y2gpIHsKIAkJCWNhc2UgMToKIAkJCQlpZiAoZlswXS50b3VjaF9t
YWpvciA+IHR1bi5wcmVzc3VyZV90YXBfdGhyZXNob2xkKQogCQkJCQlzYy0+bnRhcHMgPSAxOwpA
QCAtOTc4LDcgKzk3OCw3IEBACiAJCQkJYnJlYWs7CiAJCQl9CiAJCX0KLQkJaWYgKG4gPT0gMikg
eworCQlpZiAobnRvdWNoID09IDIpIHsKIAkJCXNjLT5kaXN0YW5jZSA9IG1heChzYy0+ZGlzdGFu
Y2UsIG1heCgKIAkJCSAgICBhYnMoc2MtPnBvc194WzBdIC0gc2MtPnBvc194WzFdKSwKIAkJCSAg
ICBhYnMoc2MtPnBvc195WzBdIC0gc2MtPnBvc195WzFdKSkpOwpAQCAtMTA1MCwxMiArMTA1MCwy
MCBAQAogCQkJaWYgKHNjLT5zY190b3VjaCA9PSBXU1BfU0VDT05EX1RPVUNIKQogCQkJCXNjLT5z
Y190b3VjaCA9IFdTUF9UT1VDSElORzsKIAotCQkJaWYgKG4gIT0gMCAmJgorCQkJaWYgKG50b3Vj
aCAhPSAwICYmCiAJCQkgICAgaC0+cTIgPT0gNCAmJgogCQkJICAgIGZbMF0udG91Y2hfbWFqb3Ig
Pj0gdHVuLnByZXNzdXJlX3RvdWNoX3RocmVzaG9sZCkgewogCQkJCWR4ID0gc2MtPnBvc194WzBd
IC0gc2MtPnByZV9wb3NfeDsKIAkJCQlkeSA9IHNjLT5wb3NfeVswXSAtIHNjLT5wcmVfcG9zX3k7
Ci0JCQkJaWYgKG4gPT0gMiAmJiBzYy0+c2Nfc3RhdHVzLmJ1dHRvbiAhPSAwKSB7CisKKwkJCQkv
KiBJZ25vcmUgbW92ZW1lbnQgZnJvbSBpYnQ9MSB0byBpYnQ9MCAqLworCQkJCWlmIChzYy0+c2Nf
c3RhdHVzLm9idXR0b24gIT0gMCAmJiAKKwkJCQkgICAgc2MtPnNjX3N0YXR1cy5idXR0b24gPT0g
MCkgeworCQkJCQlkeCA9IDA7CisJCQkJCWR5ID0gMDsKKwkJCQl9CisKKwkJCQlpZiAobnRvdWNo
ID09IDIgJiYgc2MtPnNjX3N0YXR1cy5idXR0b24gIT0gMCkgewogCQkJCQlkeCA9IHNjLT5wb3Nf
eFtzYy0+ZmluZ2VyXSAtIHNjLT5wcmVfcG9zX3g7CiAJCQkJCWR5ID0gc2MtPnBvc195W3NjLT5m
aW5nZXJdIC0gc2MtPnByZV9wb3NfeTsKIAkJCQkJaWYgKGZbMF0ub3JpZ2luID09IDAgfHwgZlsx
XS5vcmlnaW4gPT0gMCkgewpAQCAtMTA5Miw3ICsxMTAwLDcgQEAKIAkJCXNjLT5keF9zdW0gKz0g
ZHg7CiAJCQlzYy0+ZHlfc3VtICs9IGR5OwogCi0JCQlpZiAobiA9PSAyICYmIHNjLT5zY19zdGF0
dXMuYnV0dG9uID09IDApIHsKKwkJCWlmIChudG91Y2ggPT0gMiAmJiBzYy0+c2Nfc3RhdHVzLmJ1
dHRvbiA9PSAwKSB7CiAJCQkJaWYgKHNjLT5zY3JfbW9kZSA9PSBXU1BfU0NSX05PTkUgJiYKIAkJ
CQkgICAgYWJzKHNjLT5keF9zdW0pICsgYWJzKHNjLT5keV9zdW0pID4gNTApCiAJCQkJCXNjLT5z
Y3JfbW9kZSA9IGFicyhzYy0+ZHhfc3VtKSA+CkBAIC0xMTM0LDcgKzExNDIsNyBAQAogCQlzYy0+
cHJlX3Bvc194ID0gc2MtPnBvc194WzBdOwogCQlzYy0+cHJlX3Bvc195ID0gc2MtPnBvc195WzBd
OwogCi0JCWlmIChuID09IDIgJiYgc2MtPnNjX3N0YXR1cy5idXR0b24gIT0gMCkgeworCQlpZiAo
bnRvdWNoID09IDIgJiYgc2MtPnNjX3N0YXR1cy5idXR0b24gIT0gMCkgewogCQkJc2MtPnByZV9w
b3NfeCA9IHNjLT5wb3NfeFtzYy0+ZmluZ2VyXTsKIAkJCXNjLT5wcmVfcG9zX3kgPSBzYy0+cG9z
X3lbc2MtPmZpbmdlcl07CiAJCX0K
--001a1133a922d4a58604f129b86b
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
--001a1133a922d4a58604f129b86b--