Re: svn error during 'make buildkernel'?

On Sat, Aug 03, 2013 at 06:47:19PM -0400, Glen Barber wrote:
> On Sat, Aug 03, 2013 at 03:46:08PM -0700, Steve Kargl wrote:
> > On Sat, Aug 03, 2013 at 06:20:47PM -0400, Glen Barber wrote:
> > > On Sat, Aug 03, 2013 at 03:17:02PM -0700, Steve Kargl wrote:
> > > 
> > > > > BTW, you should upgrade devel/subversion anyway, since there are
> > > > > security vulnerabilities.
> > > > 
> > > > 1.7.9 works/worked fine for updating my /usr/src and my personal
> > > > svn repository.  The change to use svnlite in newvers.sh should
> > > > have an entry in UPDATING to alert users that have a too old 
> > > > svn port that they need to upgrade.  I go as far to suggest that
> > > > that the script should look for svn in the path before it looks
> > > > for svnlite.
> > > 
> > > I cannot differentiate what version of svn is used to check out the
> > > tree.  When in doubt, software in base wins, IMHO.
> > 
> > You don't need to differentiate anything.  devel/subversion
> > installs svnversion.  svnversion simply needs to be in $PATH.
> > If newvers.sh can't find svnversion in $PATH, then it can fall
> > back to /usr/bin/svnliteversion.  The install svnversion from
> > devel/subversion will in all likelihood be consistent with the
> > svn used to checkout/update /usr/src.
> > 
> 
> No, because you can set WITH_SVN=1 in src.conf, and svnlite will install
> as svn.

If someone set WITH_SVN=1, then more than likely she has already checked
out/upgraded a /usr/src with the newly anointed 1.8.0 and she has 
de-installed devel/subversion.  So, newsver.sh looks for svnversion in
$PATH.  It will find svnversion from the WITH_SVN=1 setting, the 
svnversion from devel/subversion in $PATH, or no svnversion.  If it
can't find a svnversion at all, the script falls back to looking for
a svnliteversion.  If the script can't find svnversion or svnliteversion,
then it issues an error.

-- 
Steve
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"