Re: [head tinderbox] failure on amd64/amd64

On 2012-11-08 18:48, Andriy Gapon wrote:
> on 08/11/2012 19:31 FreeBSD Tinderbox said the following:
>> cc -c -O2 -pipe -fno-strict-aliasing  -std=c99  -Wall -Wredundant-decls
>> -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith
>> -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions
>> -Wmissing-include-dirs -fdiagnostics-show-option
>> -Wno-error-tautological-compare -Wno-error-empty-body
>> -Wno-error-parentheses-equality -nostdinc  -I. -I/src/sys
>> -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include
>> opt_global.h -DGPROF -DGPROF4 -DGUPROF -fno-builtin -fno-omit-frame-pointer
>> -mno-aes -mno-avx -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
>> -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror -pg
>> /src/sys/dev/aac/aac_debug.c /src/sys/dev/aac/aac_debug.c:163:8: error: format
>> string is not a string literal (potentially insecure)
>> [-Werror,-Wformat-security] panic(reason); ^~~~~~ 1 error generated. ***
>> [aac_debug.o] Error code 1
>
>
> I think that clang complaint is rightful here.
> But the tinderbox errors that we are getting after switch make me wonder if more
> preparations should have been done before the switch to make the transition smoother.

Yes, clang has been in the tree for almost two years now.  Why didn't
the *maintainers* of these drivers fix the warnings already? ;-)

Jokes aside, I am perfectly happy to go through these warnings, and fix
them.  But that requires a feedback cycle from the driver maintainers,
so it will take a while.  That is the disadvantage of the process we are
using.

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"