Re: Remove debug echo


On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best <arundel@freebsd.org> wrote=
:
> On Tue Nov 29 11, Warner Losh wrote:
>> kill it.
>>
>> Warner
>> On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
>>
>> > Any objections to this? =A0It removes a weird line during 'make -s bui=
ldworld'
>> > output and I think it was debugging accidentally left in in 213077 by =
Warner:
>> >
>> > Index: newvers.sh
>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> > --- newvers.sh =A0 =A0 =A0(revision 228074)
>> > +++ newvers.sh =A0 =A0 =A0(working copy)
>> > @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
>> > done
>> >
>> > if [ -n "$svnversion" ] ; then
>> > - =A0 echo "$svnversion"
>> > =A0 =A0 svn=3D`cd ${SYSDIR} && $svnversion`
>> > =A0 =A0 case "$svn" in
>> > =A0 =A0 [0-9]*) svn=3D" r${svn}" ;;
>
> also...
>
> when running buildkernel via 'make -s', do we really need all those modul=
e
> printfs? i see messages for "cleandir", "obj", "depend" and "all". i thin=
k for
> 'make -s', that's pure overkill!
>
> for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 =
and
> you'll get 2680 lines of output. not really *silent*, is it? ;)

    pmake sucks as far as diagnostic output is concerned when compared
with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
and it's not a race) to determine what directory created the "Error
Code" output. With the printouts discussed here, at least you have a
chance at determining what the issue was.
    Maybe it's just me, but I like noisy builds -- otherwise the
amount of time I have to spend root-causing the issue becomes
expensive.
Thanks,
-Garrett
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"