Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with

On Tue, Nov 15, 2011 at 10:15 AM, Attilio Rao <attilio@freebsd.org> wrote:
> 2011/11/7 Kostik Belousov <kostikbel@gmail.com>:
>> On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote:
>>> Ok. =A0I'll offer one final suggestion. =A0Please consider an alternati=
ve
>>> suffix to "func". =A0Perhaps, "kbi" or "KBI". =A0In other words, someth=
ing
>>> that hints at the function's reason for existing.
>>
>> Sure. Below is the extraction of only vm_page_lock() bits, together
>> with the suggested rename. When Attilio provides the promised simplifica=
tion
>> of the mutex KPI, this can be reduced.
>
> My tentative patch is here:
> http://www.freebsd.org/~attilio/mutexfileline.patch
>
> I need to make more compile testing later, but it already compiles
> GENERIC + modules fine on HEAD.
>
> The patch provides a common entrypoint, option independent, for both
> fast case and debug/compat case.
> Additively, it almost entirely fixes the standard violation of the
> reserved namespace, as you described (the notable exception being the
> macro used in the fast path, that I want to fix as well, but in a
> separate commit).
>
> Now the file/line couplet can be passed to the "_" suffix variant of
> the flag functions.
>
> eadler@ reviewed the mutex.h comment.
>
> Please let me know what you think about it, as long as we agree on the
> patch I'll commit it.

Out of curiosity, why are function names explicitly spelled out in
panic and log messages, instead of using %s and __func__?  I've seen
this all around FreeBSD, and if there's no reason otherwise, I'd just
as soon change to a version that doesn't need updating when the
function names change.

Thanks,
matthew
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"