Re: ANSI-fy of ranlib, ruptime and rdist [patches]
-On [20040722 23:12], Douwe Kiela (virtus@wanadoo.nl) wrote:
>http://virtus.ath.cx/dfbsd/ruptime.c.diff
I chose to use FreeBSD's v1.15.
Please do not mix white space and code changes in a diff. I am still not
sure why you added newlines after the opening accolade of some functions.
Also, to proper use ANSI functions functions without any arguments should be
set to func(void), e.g. usage(void). Also I used int main(int argc, char
*argv[]) instead of int main(int argc, char **argv), since the former is,
in my opinion, more easily read as being an array of pointers to char.
Thanks for the reminder and patch though. :)
--
Jeroen Ruigrok van der Werven <asmodai(at)wxs.nl> / asmodai / kita no mono
Free Tibet! http://www.savetibet.org/ | http://www.tibet.nu/
http://www.tendra.org/ | http://diary.in-nomine.org/
The Wheels of Life, they turn, ..., without me...
討論串 (同標題文章)
完整討論串 (本文為第 2 之 20 篇)：