acpica5 and acpi sub-modules (Re: cvs commit: src/sys/dev Makefi
--u3/rZRmxL6MmkK24
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hi.
On Mon, Apr 26, 2004 at 10:11:30AM +0900, YONETANI Tomokazu wrote:
> On Sun, Apr 25, 2004 at 01:42:25PM +0000, David Rhodus wrote:
> > Matthew Dillon wrote:
> >
> > >:drhodus 2004/04/23 21:11:10 PDT
> > >:
> > >:DragonFly src repository
> > >:
> > >: Modified files:
> > >: sys/dev Makefile
> > >: Log:
> > >: Add in the new acpica5 to the device build path.
> > >:
> > >: Revision Changes Path
> > >: 1.3 +1 -1 src/sys/dev/Makefile
> > >:
> > >:
> > >:http://www.dragonflybsd.org/cvsweb/src/sys/dev/Makefile.diff?r1=1.2&r2=1.3&f=h
> > >
> > > Ohhh... I don't know about that. I don't think I ever did any testing
> > > of it, or entirely finished bringing it in. This code should be
> > > considered extremely experiemental.
> > >
> > > Also there might be an issue with the boot loader automatically loading
> > > the module. It might be a good idea to rename the module for now.
> > >
> > >
> >
> > On the 20'something types of boards I tested this on, I found no
> > problems. Though
> > yes, it is a good idea to wait till we get past a stable tag for this.
>
> Does acpica5 successfully load when you're using UP kernel?
> I have only tested it with UP kernel, but it complains that
> required module `pci' is missing and wouldn't load. If I remove
> MODULE_DEPEND() from /sys/i386/acpica5/acpi_pci.c, it fails
> saying undefined symbol lapic_init . I've grep'ped it with
>
> $ grep -r lapic_init /sys/
>
> but no definition was found.
(Am I in his killfile?)
Ok, here's a patch that make acpica5 module and its sub-modules load
on my system. At the moment, the only acpi sub module is acpi_toshiba
because that's the only sub-module I can test. Acpi sub-modules are
kernel modules to access some special hardwares installed on some
PCs. acpi_toshiba is one of such sub-modules needed to do CPU throttle
and other things on Toshiba notebook PCs.
What the patch does:
- isolate module build directory from /sys/dev/acpica5 into
/sys/dev/acpi, so that sub-module can be built at the same time,
and new sub-modules can be populated without messing up acpica5
directory. /sys/dev/acpi roughly corresponds to /sys/modules/acpi
of FreeBSD. Makefiles are brought from FreeBSD without removing
$FreeBSD$ keywords.
- add "gross hack" from /sys/i386/i386/machdep.c,1.584 of FreeBSD,
and remove stale dependency to non-existing `pci' module, so that
acpi module loads.
- catch up with the change in src/sys/i386/include/acpica_machdep.h,v 1.5
from FreeBSD to quiet the warning. There's another place where it
produces `implicit declaration' warning for isab_attach(), but I'm not
sure how to fix this.
To apply the patch:
$ zcat acpi5.gz | patch -d /path/to/sys -p0
Tested with both gcc2 and gcc3 on UP kernel (and I'm using it now).
The patch does not connect /sys/dev/acpi to buildkernel, so you have to
either build and install it manually, or add `acpi' to SUBDIR in
/sys/dev/Makefile, to test this.
Thanks.
--u3/rZRmxL6MmkK24
Content-Type: application/x-gunzip
Content-Disposition: attachment; filename="acpi5.gz"
Content-Transfer-Encoding: base64
H4sICFqtkEACA2FjcGk1AMVbe1MbORL/2/4UOpKqsDHy2AYCeI+9GGyCd3kVhly2bq+m5iF7
ZpnXjTQ2VI7vfi1p3h7jB2SPIrhHUrekVqsfP0+Gnkkeu8gkU0UzAlu51B7I2HZI/fj1P/Xb
0xHiwqrkm/Z4jPBVRQ/GGCm82Yscp9ZGv2oeah8dtFCr1RW/CLfgp95oNOa5a50j1AtC1Gm1
9lDrU3f/qNvqxAyfPwOx00KN9s4e+vy53niH3vdDbeJ7Z87T+3qj3hjdn/SHt8c1LhLxPyrz
qWXrWr3RtD3DiUxS+7tOzSaNdNMOm+7DL/XhAg1yhh+tRTHHQk2K3ldpk0soavSgC0rd3ZvX
aPtAqHT0+6h3ejM87f3jGBm+x0JbVxKxhoYjz37EIGm33Wntco2/E2puWihWL0VbgaOxsR+6
wEO8adPaaiJ0Z9kUwS+zCCIatQllaKY9IeYjIyQaI0IScn1Qhk1MFLNCa73x/nvz+uRXONdn
Rc7VRdB0en8rmprN+Pf993Ttz0q8mpih3qgZAWfqXVyMbk+fOXnXu/0yuHvme8hNUF77GlOV
WWFSe4z+hf6GsIkqpkD//pmrw0PuA5hi1YifwWz40jWWX/t/0R/QSEFJmKAPVFHVs5CQk1Ff
VYFO7wM8fZgbqxljGMsvgAW0KcaOnSd4+oB+yWml6ZEZMLpThMel5pLuYEmjxjGaOyP0glKB
r3zp/hLftcSBvYEXe8GVwcU76rb35y/eUerL4nPsIhoaCn2iClyHyCG0QvbOFLWbu0K00mor
rUPUhmt92N3tIO9PBw0ewdwr/GPiBNEWWHHeSWxB303v7rxbq7b3y97p+fBqoPZuT8+fY2ew
X6tx66pi0COqBIaNarUFY2IJyjU1l41Z2D9/ERkJg5DAX8W0aaAxwyLh+rzkkRgR24Qz0EK6
Kh+ZEo/RVfdmaaE500Ky4nBPcwkowFh1fEioH4UGoSuOZ5rukJUXHzHbsZkdS683fru87teO
ReCQIYQPRKc9FC+i3jg9u+h94X4FITzMPIl8qLSSqq4FnjpxWjWTQqxxzKaBTGp7NhOES5jl
yzaXWaYGrTkGX/+TGHKgHxi+SQTJN0gFNePGIynH18wC74wafiAZZpRBzAMSrIDbgaAmAUk+
dechx0qmrk0N0ReSie17kpx4sGhBUkN+Po7hyAuMj2MyjcU/guufCNZHCOxje5KQ05BJUgTi
PPujGbmB6EsUBZRj2r6gkkU9unBbHgt8wv5Enw93YtLOyE5G7mbkpwI33CY5a7ZbIKknNcZJ
35mmZFDgpcwP5TBBeSnp65J8ooy4goxPLWW2ZiJ0GciayaOwZrAAKgjqELEma8Zsl4Q5Lo9q
BtgsHwak4/iGoGLNeZRMNUcQ0sJyfNJAoCfRlpeZl0eFLxEUJVpoWAXWxOA8OtO4qQDBTzqe
6XHMJcYkiMyxBhS0zTmDzH6DdK6AxiaaG88gKImuZM4gmTOgZXsLqWaaoBwUUkNzDEnEVgVk
rJOQcgPKMdnhf0SzY1MmCJe4fvgkSWlkIS2fVpjMjpieGjHTJyT9hMMQpO3BbXNyrEyHtchh
yaaYnkmDi+L7vDti8XmmnBEzHFsXXaCoJ0GYRI8mMeUQsVW4D9PCjBGbOL4ujgdmlK4mYq7G
LEnITUYsOf8cY6pj7iivR33kaE8kFIlxnHuh2GxFvaMZwqgErWsMotJT+hgxJm6TeDJcnfu2
+CGIskmlQFX4MUHZVNMT2rHNuZEQaB60CUmGBIadI/U8rcqllvl5T57Ln5EwFFdCPCfRKXmG
rDl08/qN5cRXMxUKi/Ue8qMg2+jL0yq0ncfBFVjhacgDehgFTD5eJrYI9AgSCp6RlfhHcEc0
Nx7y5PG7ysk7HiQlOfCmduh7rnD1Ga8fMDVOlzkJWVNMmabO0+RkHOSXtkFUewzdMEgSfIMJ
oUsKDkoQ0ljEVie2N0E0CgI/ZPVG/wREQizSDdcUAUvniZLzJMgkdOk8KRQ+3tShbGN89zEr
j2Nwn4JIhECdRzEpJo2AemqvKYOrR+OxOBjTTVyd6Wbh082CqgtHHRoZ5RQFiTbJnk7oSm8k
s9uxSCXUy9439e78dtDrj7JcAvfLfcfvv5eboKZpEg9Kg5y0q2t1NLjs3Zxf3w7m5ZV657j7
g5P7L3NccWt8y99/F3uEydPD76K0EmnUiGH5aOudCc8eQf3+CWpvFeo1Pq9DyYv82JtjkUvl
tnKpGRbIxjQgBlTgBuKHA3ZjWEijSEQ/ZQYCoyBdtLhlLvCZIjKKRz5EHKuVPUciQHN9pGXE
Mzo+Rlv27uGnrVScq5nibiSrOr0Y9K7OhheDdK4q4eLZLz2DhaJMpQVBFaVooyS8W5I2Einu
Ze83WLashletj9IKS1ThNS4ClsTLrOM1pBTqNgFePUBdKKCr6jo6wbz+knp6frLKunp+2Mb1
9ZyoMmS4d1ANcLVXr7Pn5hD1djutt0FWG6p5qLcPV6q3a4vr7dqapsCLp+NarQhuJt6l9qOq
pdKMcN9zsasqPL1gtSWbzV+UH2SphSnK9lno5FZZ1VHrtNEZ0TMbO+y2DqWN1cAwhJWuYs3c
HrkpgkVyswSDxD8A+MF5Q8ykVm2sYNgdBbaZ7s60Ifv1EpF1vBY0DOMXAUqL0KQ/6nh+cA5J
KvXH0FGpuaJpLaxoHcYcULQOW4oSLWPKQUTLhmb40AqDc+jQCqNz2NAKo3PI0LKhOViIj67j
PC6EuRGXcSG8Ci5U5dsqHRteFwbCr4CB8OYwEN4UBsKvg4HwhjAQfhUMhF8BA+HXwEB4IxgI
bwgD4c1hILw5DITXhIHwWjAQ3gQGwpvBQHhzGAhvDAPhDWEgvCkMhOdgIOEXMxgIv0vGvB0M
hFeGgfArYSD8RjAQXgkGwhUwEH4lDIRfAQPhFWEgvDEMJIxlHgbCm8NAeF0YCL8VDIRXg4F4
3lkFA+E1YSAc4xB4AQyEX4SB5rkl4IMrYSBchoFwFYyDV4CBsISBXuIvw0DpUrmtrAED4U1g
ILwQBsJFGChd1VvBQPhlGAh2vxQGwi/CQCtgQHgJBrSo6hdH80av2eDK12x4GFnlNZuX3rHB
i9+xwQXpK7xjs9oLNvhNXrDBVS/Y4DVesMGbvmCDl75gg1Pnv94LNsILVoIvuAp+yeL1GwMw
iuW7RJFhW0m1oRhTqlSBEtk6dqZ1KJZDGyIeBK4QPiBb9DhUEeM3EcIhBy5ySy9jN1nXKujN
Is48trjX3e10W7t5LKezt3OAGvzjE0dzUB31b4dfB7cq1LL3F4PtRNSOiM87WVJihvaUhKJZ
hbkNR6N0B7Xg96ef60hyqyBoNLy+yklpQy+Oe/uDm8FVvzgFjJC/XEod8dAMbtz2WD2bGjyB
qdpTLdyOMwrGd7+D0icIAo65w7nQzLINawdFQAcshL6PEH0jh/2U2BF334r4kwaBv96IKhax
0IL2DwomtH+AsoVzE6qQVdvPjIDjvvtd4ErMB+Rx+6liKxjPbrfV6XYOc8bT2Ts6ALNpiM92
qyMM6LmO3onYh5SPyPNFmP+owFk23tljUPkY9Qdf1R64Rt6S3HFXBm5FAwOGg21a/MuBhvKx
3kAf0U3oT20ex1mko3HkGQw0AeHcB/cIro8Hi8te/w5xoYh4EaTPGpTKcP6iT76nA3IeSOgR
B0lwEs1sx0E8tUbaROPFFQSWeMTMZpYfMfRBWhTiq/rQ5DKEnG/fviGcxioNTUKfUmRB+SDG
KPXG1LfNeoOzqbz4h1o9VLOFbUMyGhlMiM01o48Z/VO98b3eEG8ocll8YtsX42Uc3M4Mmteq
wtZ3O/Bkx3YP/3SNEimnBpYUhR7avrq/uICLJQXzS5VINXlx5BA1sL1tOaHh+w82gZujcnHQ
XhI1uPo2vK6UBTWrOoVMGDa6mijcTuVIxcWCEtUVxOQ0k580JK4WLJlWakaOWXk3FHZDHqHa
Za9WDBflufabyAl8Rwtt9rR4r4alhWD7DNy0Za8lG7zOZAK1KaSNS8QTc0Li0S/OII/VKRiw
ECVaEpvVfZ/xGr5k/AkjBxxKdl82BifdgzNlqthAaR75CL0xKS4NH7hcQ0Xh6QG8NMGaZ1Cc
IX8MSydZ7STeJV+Zo8z1iiTGpg+OphOHO14Iu+B4C+ExlykbWlotWf+vQLlgOWslXYV9ZHFz
gehaZw+NSMBD4S4Phfvt7v5RKQNbIqCYiO1DFpf/krezy/Mw8ZdHUYgy1/d36PoM3Z0P0P1o
IMnhCI2uz+7+2bsd7KDB18EVGp6hXv/rcDToJ4Nvrkej4cnwYnj3OzQJUaP703PU7132vgya
vKGOoXH+W7slygVF7jU78su2XaV1qHQ6QHb3jrqQnv5p6cm3yBvK3o/lHintFmq1u+297l4n
J5dvpOpbweWS26nkzl52eGZoQSJAM+k8SZE5Mf//OQ3+IXPiBLE4vb68gQL8Nk5cB1d36v3w
6u7THhI/kUftiQellOOD+fE/GatAS+AY1aveHaTXan/4ddgf8KxIOFgUQ38jwvpkrEF+OvRY
eAk339nmN537AIff4XxypaqywlR51Q1LUs9Vle/if0G0sINTNQAA
--u3/rZRmxL6MmkK24--